Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript-migration] initial ts config and the first calendar_container.jsx module #4704

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

mirus-ua
Copy link
Contributor

@mirus-ua mirus-ua commented Apr 18, 2024


name: initial ts config and the first calendar_container.jsx module

Description

Linked issue: #4700
Problem

Changes
Was added initial ts config and rollup plugins + migrated the first functional component to TS

To reviewers:
I've added babel preset-typescript instead of using ts-jest because right now, during the migration, better to only transpile code and not check types validity in tests

Screenshots

Знімок екрана 2024-04-18 о 16 36 00
Знімок екрана 2024-04-18 о 16 36 19

Contribution checklist

  • I have followed the contributing guidelines.
  • I have added sufficient test coverage for my changes.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:
  • Comments posted to any areas of potential concern or improvement.
  • Detailed feedback or actions needed to resolve issues that are found.
  • Turnaround times vary, but we aim to be swift.

@mirus-ua you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 61
- 18

34% JSON with Comments
23% JavaScript
22% JSON
22% TSX

Generated lines of change

+ 49
- 3

Type of change

Feature - These changes are adding a new feature or improvement to existing code.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.12%. Comparing base (171da9d) to head (7a2fd93).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4704      +/-   ##
==========================================
- Coverage   97.13%   97.12%   -0.01%     
==========================================
  Files          28       27       -1     
  Lines        2685     2677       -8     
  Branches     1147     1142       -5     
==========================================
- Hits         2608     2600       -8     
  Misses         77       77              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see we're introducing TS here! Just one suggestion below.

Image of Simon Simon


Reviewed with ❤️ by PullRequest

tsconfig.json Show resolved Hide resolved
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see a typescript migration! I left one comment around the naming of the build script in package.json.

I would also recommend making sure that calendar_container.tsx is showing up correctly in the dist folder when building for production to verify that this setup is working correctly.

Image of Joey G Joey G


Reviewed with ❤️ by PullRequest

package.json Outdated Show resolved Hide resolved
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest reviewed the updates made to #4704 up until the latest commit (7a2fd93). No further issues were found.

Reviewed by:

Image of Joey G Joey G

@mirus-ua
Copy link
Contributor Author

@martijnrusschen hello. I'm not sure that I can increase the test coverage because the PR is mostly about configs 😅
Can we handle this somehow?

@martijnrusschen martijnrusschen merged commit ba11f71 into Hacker0x01:main Apr 19, 2024
5 of 6 checks passed
@martijnrusschen
Copy link
Member

Nice one! Glad to see this coming along!

@mirus-ua mirus-ua deleted the feature/ts-configs branch April 19, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants