[typescript-migration] portal.js

[Olenka-Yurchuk]

---

name: Migrate portal.jsx

Description

Linked issue: #4700

Changes
portal.jsx was migrated to ts + added JSDocs

Contribution checklist

• I have followed the contributing guidelines.
• I have added sufficient test coverage for my changes.
• I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

[pullrequest]

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:

• Comments posted to any areas of potential concern or improvement.
• Detailed feedback or actions needed to resolve issues that are found.
• Turnaround times vary, but we aim to be swift.

---

@Olenka-Yurchuk you can click here to see the review status or cancel the code review job.

[pullrequest]

PullRequest Breakdown

Reviewable lines of change

+ 52
- 36

59% TSX
41% JavaScript

Type of change

Feature - These changes are adding a new feature or improvement to existing code.

[martijnrusschen]

Thanks, CI is failing on prettier can you run prettier locally and commit those changes?

[pullrequest]

The update to typescript here looks good. The only callout was already made by another reviewer with the update of the package manager in the package.json and confirming why that would be included in this PR. Once that is confirmed or removed this should be good to go.

Logan A

---

Reviewed with ❤️ by PullRequest

[pullrequest]

I have just one concern with these changes, noted inline.

Graham C

---

Reviewed with ❤️ by PullRequest

[pullrequest]

I don't believe this should be added as part of this PR. This change is not related.

🔺 Bug (Critical)

Graham C

[mirus-ua]

As for me, this is OK, because w/o this line yarn will use your local version and it could be not a 1.x

[pullrequest]

I don't object to the change, just to the change being included in this PR. This belongs in a separate PR IMO.

Graham C

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.26%. Comparing base (1606cf3) to head (f93fcbf).
Report is 10 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4722      +/-   ##
==========================================
+ Coverage   97.16%   97.26%   +0.09%     
==========================================
  Files          18       11       -7     
  Lines        1765     1461     -304     
  Branches      742      651      -91     
==========================================
- Hits         1715     1421     -294     
+ Misses         50       40      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pullrequest]

PullRequest reviewed the updates made to #4722 up until the latest commit (f93fcbf). No further issues were found.

Reviewed by:

Graham C