[typescript-migration] time.jsx

[yuki0410-dev]

name: Migrate time.jsx

Description

Linked issue: #4700

Changes time.jsx was migrated to ts

Contribution checklist

• I have followed the contributing guidelines.
• I have added sufficient test coverage for my changes.
• I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

[pullrequest]

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:

• Comments posted to any areas of potential concern or improvement.
• Detailed feedback or actions needed to resolve issues that are found.
• Turnaround times vary, but we aim to be swift.

---

@yuki0410-dev you can click here to see the review status or cancel the code review job.

[pullrequest]

PullRequest Breakdown

Reviewable lines of change

+ 81
- 63

99% TSX
1% JavaScript (tests)

Type of change

Feature - These changes are adding a new feature or improvement to existing code.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.28%. Comparing base (dba4a60) to head (f6b886d).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4726      +/-   ##
==========================================
+ Coverage   96.85%   97.28%   +0.43%     
==========================================
  Files          13       12       -1     
  Lines        1589     1476     -113     
  Branches      706      652      -54     
==========================================
- Hits         1539     1436     -103     
+ Misses         50       40      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pullrequest]

Overall the code change looks good and matches the description regarding migration to TS. I just provided some minor comments.

Xiaoyong W

---

Reviewed with ❤️ by PullRequest

[pullrequest]

PullRequest reviewed the updates made to #4726 up until the latest commit (c349829). No further issues were found.

Reviewed by:

Xiaoyong W

[pullrequest]

Only one nit regarding a return type not being specified. Other than that, I see no issues.

Jacob

---

Reviewed with ❤️ by PullRequest

[pullrequest]

ISSUE: @typescript-eslint/explicit-module-boundary-types (Severity: Medium)
Missing return type on function.

Remediation:
There is no return type specified for this function.

🤖 powered by PullRequest Automation 👋 verified by Jacob

[yuki0410-dev]

Corrected.

@mirus-ua
However, this should be detected by ESLint in CI, so the lint rule may need to be modified.

[pullrequest]

PullRequest reviewed the updates made to #4726 up until the latest commit (1b29b33). No further issues were found.

Reviewed by:

Jacob

[pullrequest]

PullRequest reviewed the updates made to #4726 up until the latest commit (f6b886d). No further issues were found.

Reviewed by:

Xiaoyong W