Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid time error when selecting excluded month with keyboard #4732

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

ryantanrk
Copy link
Contributor

@ryantanrk ryantanrk commented Apr 26, 2024


name: Pull Request
about: Fixes the date picker throwing an invalid time error when selecting excluded month with the keyboard
title: fix: invalid time error when selecting excluded month with keyboard
labels: ""
assignees: ""

Description

Linked issue: #4731

Problem
When an excluded month is selected with the keyboard, the month appears to not be keyboard selected, and when the arrow keys are used again, the Invalid time value error is thrown
image

Changes
Added a isMonthDisabled check to the onMonthKeyDown function

Screenshots

image

Contribution checklist

  • I have followed the contributing guidelines.
  • I have added sufficient test coverage for my changes.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

@martijnrusschen
Copy link
Member

Please check the CI output

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:
  • Comments posted to any areas of potential concern or improvement.
  • Detailed feedback or actions needed to resolve issues that are found.
  • Turnaround times vary, but we aim to be swift.

@ryantanrk you can click here to see the review status or cancel the code review job - or - cancel by adding [!pr] to the title of the pull request.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 29
- 3

69% JavaScript (tests)
31% JavaScript

Type of change

Fix - These changes are likely to be fixing a bug or issue.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here, on fixing this issue and providing test coverage. 🎉

Image of Graham C Graham C


Reviewed with ❤️ by PullRequest

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only remark is something unrelated to this PR. This PR, own its own, looks solid.

Image of Jacob Jacob


Reviewed with ❤️ by PullRequest

src/month.jsx Show resolved Hide resolved
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest reviewed the updates made to #4732 up until the latest commit (7f9fb19). No further issues were found.

Reviewed by:

Image of Graham C Graham C

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.26%. Comparing base (882867c) to head (7f9fb19).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4732   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files          11       11           
  Lines        1461     1462    +1     
  Branches      651      652    +1     
=======================================
+ Hits         1421     1422    +1     
  Misses         40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martijnrusschen martijnrusschen merged commit 0cb6f84 into Hacker0x01:main Apr 26, 2024
6 checks passed
@ryantanrk ryantanrk deleted the fix/disabled-month-kb branch April 26, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants