Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript-migration] year.jsx #4756

Merged

Conversation

Olenka-Yurchuk
Copy link
Contributor


name: Migrate year.jsx

Description

Linked issue: #4700

Changes
year.jsx was migrated to ts + added JSDocs

Contribution checklist

  • I have followed the contributing guidelines.
  • I have added sufficient test coverage for my changes.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:
  • Comments posted to any areas of potential concern or improvement.
  • Detailed feedback or actions needed to resolve issues that are found.
  • Turnaround times vary, but we aim to be swift.

@Olenka-Yurchuk you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 186
- 79

97% TSX
3% TypeScript
1% JavaScript (tests)

Type of change

Feature - These changes are adding a new feature or improvement to existing code.

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.98%. Comparing base (0cb6f84) to head (806c335).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4756      +/-   ##
==========================================
- Coverage   97.26%   96.98%   -0.29%     
==========================================
  Files          11       10       -1     
  Lines        1462     1292     -170     
  Branches      642      582      -60     
==========================================
- Hits         1422     1253     -169     
+ Misses         40       39       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me and matches the description regarding ts migration for year.jsx

Image of Xiaoyong W Xiaoyong W


Reviewed with ❤️ by PullRequest

@martijnrusschen martijnrusschen merged commit 84e7989 into Hacker0x01:main May 3, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants