Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript-migration] eslintrc #4757

Merged
merged 2 commits into from
May 21, 2024

Conversation

yuki0410-dev
Copy link
Contributor

@yuki0410-dev yuki0410-dev commented May 3, 2024

Description

Linked issue: #4700

Changes
eslintrc migrated for ts

Screenshots

To reviewers

Contribution checklist

  • I have followed the contributing guidelines.
  • I have added sufficient test coverage for my changes.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This pull request was not sent to the PullRequest network because the pull request is a draft.

@yuki0410-dev yuki0410-dev marked this pull request as ready for review May 21, 2024 15:08
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:
  • Comments posted to any areas of potential concern or improvement.
  • Detailed feedback or actions needed to resolve issues that are found.
  • Turnaround times vary, but we aim to be swift.

@yuki0410-dev you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 255
- 179

38% TypeScript
23% JavaScript
22% TSX
17% Other

Generated lines of change

+ 390
- 39

Type of change

Feature - These changes are adding a new feature or improvement to existing code.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of changes related to the updated eslint config and let to const here. Overall the updates look good and should be good to go.

Image of Logan A Logan A


Reviewed with ❤️ by PullRequest

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The improved eslint file looks good and the subsequent linter fixes are great to see! No blocking concerns here.

Image of Jonah Jonah


Reviewed with ❤️ by PullRequest

.eslintrc.js Show resolved Hide resolved
@yuki0410-dev yuki0410-dev force-pushed the feat/4700_eslint branch 2 times, most recently from 5862697 to 5f8e374 Compare May 21, 2024 18:17
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest reviewed the updates made to #4757 up until the latest commit (31b22c2). No further issues were found.

Reviewed by:

Image of Jonah Jonah

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (b4df97e) to head (31b22c2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4757   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files           6        6           
  Lines          61       61           
  Branches       19       19           
=======================================
  Hits           60       60           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martijnrusschen martijnrusschen merged commit 56ded07 into Hacker0x01:main May 21, 2024
6 checks passed
@yuki0410-dev yuki0410-dev deleted the feat/4700_eslint branch May 21, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants