-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[typescript-migration] eslintrc #4757
[typescript-migration] eslintrc #4757
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1cfa34c
to
49f96ce
Compare
49f96ce
to
d0e677a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!
What to expect from this code review:
- Comments posted to any areas of potential concern or improvement.
- Detailed feedback or actions needed to resolve issues that are found.
- Turnaround times vary, but we aim to be swift.
@yuki0410-dev you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PullRequest Breakdown
Reviewable lines of change
+ 255
- 179
38% TypeScript
23% JavaScript
22% TSX
17% Other
Generated lines of change
+ 390
- 39
Type of change
Feature - These changes are adding a new feature or improvement to existing code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of changes related to the updated eslint config and let
to const
here. Overall the updates look good and should be good to go.
Reviewed with ❤️ by PullRequest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The improved eslint file looks good and the subsequent linter fixes are great to see! No blocking concerns here.
Reviewed with ❤️ by PullRequest
5862697
to
5f8e374
Compare
5f8e374
to
31b22c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4757 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 6 6
Lines 61 61
Branches 19 19
=======================================
Hits 60 60
Misses 1 1 ☔ View full report in Codecov by Sentry. |
Description
Linked issue: #4700
Changes
eslintrc migrated for ts
Screenshots
To reviewers
Contribution checklist