Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export ReactDatePickerCustomHeaderProps IF #4931

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

yuki0410-dev
Copy link
Contributor

Description

Linked issue: closes #4906

Problem
See issue.

Changes
export ReactDatePickerCustomHeaderProps IF

Screenshots

To reviewers

Contribution checklist

  • I have followed the contributing guidelines.
  • I have added sufficient test coverage for my changes.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:
  • Comments posted to any areas of potential concern or improvement.
  • Detailed feedback or actions needed to resolve issues that are found.
  • Turnaround times vary, but we aim to be swift.

@yuki0410-dev you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 2
- 0

100% TSX

Type of change

Minor Update - These changes appear to be a minor update to existing functionality and features.

Copy link

codecov bot commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.66%. Comparing base (c8c9f6f) to head (5d1cfc4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4931   +/-   ##
=======================================
  Coverage   96.66%   96.66%           
=======================================
  Files          28       28           
  Lines        3264     3264           
  Branches     1343     1356   +13     
=======================================
  Hits         3155     3155           
+ Misses        109      105    -4     
- Partials        0        4    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach should resolve the issue and seems okay to me. Alternatively, you could update places where you import ReactDatePickerCustomHeaderProps to specify the /calendar path.

Image of Jonah Jonah


Reviewed with ❤️ by PullRequest

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a simple change; I have no concerns if the team wants this.

Image of Jacob Jacob


Reviewed with ❤️ by PullRequest

@martijnrusschen martijnrusschen merged commit b724db6 into Hacker0x01:main Jun 23, 2024
6 checks passed
@yuki0410-dev yuki0410-dev deleted the bugfix/4906 branch June 29, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

type ReactDatePickerCustomHeaderProps is no longer exported
2 participants