Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump @rollup/plugin-typescript from 11.1.6 to 12.1.2 #5282

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 16, 2024

Bumps @rollup/plugin-typescript from 11.1.6 to 12.1.2.

Changelog

Sourced from @​rollup/plugin-typescript's changelog.

v12.1.2

2024-12-15

Bugfixes

  • fix: path validation issue in validatePaths function (#1800)

v12.1.1

2024-10-16

Bugfixes

  • fix: allow for files to be nested in folders within outDir (#1783)

v12.1.0

2024-09-22

Features

  • feat: add transformers factory. (#1668)

v12.0.0

2024-09-22

Breaking Changes

  • fix!: correctly resolve filenames of declaration files for output.file (#1728)
Commits
  • 3952b73 chore(release): typescript v12.1.2
  • e58d29c fix(typescript): path validation issue in validatePaths function (#1800)
  • c358dae chore(release): typescript v12.1.1
  • cc55c44 fix(typescript): allow for files to be nested in folders within outDir (#1783)
  • 28b9701 chore(release): typescript v12.1.0
  • 2c09b57 feat(typescript): add transformers factory. (#1668)
  • 5afda37 chore(release): typescript v12.0.0
  • a85b649 fix(typescript)!: correctly resolve filenames of declaration files for `outpu...
  • See full diff in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 16, 2024
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This pull request was not sent to the PullRequest network because the author name contains "dependabot".

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.87%. Comparing base (a8099d8) to head (5b21389).
Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5282   +/-   ##
=======================================
  Coverage   96.87%   96.87%           
=======================================
  Files          30       30           
  Lines        3358     3358           
  Branches     1414     1427   +13     
=======================================
  Hits         3253     3253           
+ Misses        105      103    -2     
- Partials        0        2    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/rollup/plugin-typescript-12.1.2 branch from 532bd63 to 85aff7a Compare January 10, 2025 07:33
@martijnrusschen
Copy link
Member

@dependabot rebase

Bumps [@rollup/plugin-typescript](https://github.com/rollup/plugins/tree/HEAD/packages/typescript) from 11.1.6 to 12.1.2.
- [Changelog](https://github.com/rollup/plugins/blob/master/packages/typescript/CHANGELOG.md)
- [Commits](https://github.com/rollup/plugins/commits/typescript-v12.1.2/packages/typescript)

---
updated-dependencies:
- dependency-name: "@rollup/plugin-typescript"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/rollup/plugin-typescript-12.1.2 branch from 85aff7a to ad9ec1d Compare January 21, 2025 16:47
@martijnrusschen
Copy link
Member

@balajis-qb I'm trying to clear the queue of open PRs, there's a breaking change here and I don't have time to look into it, would you mind giving this one a go?

@balajis-qb
Copy link
Contributor

balajis-qb commented Jan 22, 2025

Hi @martijnrusschen,
I analyzed the issue. It's because of the @rollup/plugin-typescript upgrade we made. The exact issue is with the usage of sub-directory for es build (dist/es/index.js)
image

I tried updating the output path from dist/es/index.js to dist/index-es.js and it worked without any issue. Actually we have an open issue reported in @rollup/plugin-typescript - rollup/plugins#1813 rollup/plugins#1772 - Seems like there is some issue with their validation logic

If you feel updating output file path for es build from dist/es/index.js to dist/index-es.js wont work, then I think we can use v11.1.6 for now until the issue is fixed. Let me know if I can update the output path.

If needed I'll try to figure out any temporary fix without changing the output file path.

- Updated as @rollup/plugin-typescript v12.1.2 has some issue in parsing the nested directories of declarationDir ("./dist")

Related issues
rollup/plugins#1813
rollup/plugins#1772
@balajis-qb
Copy link
Contributor

Hi @martijnrusschen,
In this PR I just updated the output path of the ES Build - #5339

If you feel this wont work, then I think we can use v11.1.6 for now until the issue is fixed.

@martijnrusschen martijnrusschen merged commit ba9d2b4 into main Jan 22, 2025
6 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/rollup/plugin-typescript-12.1.2 branch January 22, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants