Enhance DatePicker behavior for date range selection and refocus logic#5793
Merged
martijnrusschen merged 1 commit intoHacker0x01:mainfrom Aug 18, 2025
Merged
Conversation
- Updated the DatePicker component to improve handling of date selection completion when using the selectsRange prop. - Added logic to determine if the input should refocus based on the selection of start and end dates. - Introduced new tests to verify refocus behavior for various date range scenarios, ensuring correct functionality when selecting dates in a range. This update addresses cases in which date selection happens through keyboard, which will avoid unnecessary refocus to the date input when the date is partialy selected. Closes Hacker0x01#5784
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5793 +/- ##
==========================================
- Coverage 97.23% 97.23% -0.01%
==========================================
Files 30 30
Lines 3436 3435 -1
Branches 1455 1440 -15
==========================================
- Hits 3341 3340 -1
Misses 95 95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Linked issue: #5784
Problem
As mentioned in the linked ticket and the comments, the date range picker has an issue in it's refocus logic. If we select a start date, the focus should remain in the selected start date, as the selected date is not complete, so that user can use keyboard arrows to select the end date. But now for each date selection, regardless of
startDateorendDate, we always change the focus back to date input on selection.Changes
DatePickercomponent to improve handling of date selection completion when using theselectsRangeprop.This update addresses cases in which date selection happens through keyboard, which will avoid unnecessary refocus to the date input when the date is partially selected.
startDate, the focus won't changeendDate, the focus will move back to Date InputContribution checklist