No way to invoke svn/git daemons with unvalued parameters #200
Comments
BenoitPerrot
pushed a commit
to criteo-forks/private-bower
that referenced
this issue
Nov 19, 2015
Several options of git/svn daemons are not expecting any value,
and no "=" should be appended to the mnemonic when used.
Note that the way to identify such a parameter is tricky and
debatable. The choice made here is to consider empty strings as a
marker for unvalued parameters. To give an actual empty string to
a parameter, a string with a space can still be used.
For example the following configuration:
{
...
"repositoryCache": {
"git": {
"foo": " "
"verbose": "",
"syslog": "",
"max-connections": 42
}
}
}
Would make private-bower invoke the git daemon as follows:
git-daemon --foo= --verbose --syslog --max-connections=42
(Notice the two spaces after "--foo=", effectively giving an empty
value to the "foo" parameter)
Fixes Hacklone#200.
BenoitPerrot
pushed a commit
to criteo-forks/private-bower
that referenced
this issue
Nov 19, 2015
Several options of git/svn daemons are not expecting any value,
and no "=" should be appended to the mnemonic when used.
Note that the way to identify such a parameter is tricky and
debatable. The choice made here is to consider empty strings as a
marker for unvalued parameters. To give an actual empty string to
a parameter, a string with a space can still be used.
For example the following configuration:
{
...
"repositoryCache": {
"git": {
"foo": " "
"verbose": "",
"syslog": "",
"max-connections": 42
}
}
}
Would make private-bower invoke the git daemon as follows:
git-daemon --foo= --verbose --syslog --max-connections=42
(Notice the two spaces after "--foo=", effectively giving an empty
value to the "foo" parameter)
Fixes Hacklone#200.
BenoitPerrot
pushed a commit
to criteo-forks/private-bower
that referenced
this issue
Nov 19, 2015
Several options of git/svn daemons are not expecting any value,
and no "=" should be appended to the mnemonic when used.
Note that the way to identify such a parameter is tricky and
debatable. The choice made here is to consider empty strings as a
marker for unvalued parameters. To give an actual empty string to
a parameter, a string with a space can still be used.
For example the following configuration:
{
...
"repositoryCache": {
"git": {
"foo": " "
"verbose": "",
"syslog": "",
"max-connections": 42
}
}
}
Would make private-bower invoke the git daemon as follows:
git-daemon --foo= --verbose --syslog --max-connections=42
(Notice the two spaces after "--foo=", effectively giving an empty
value to the "foo" parameter)
Fixes Hacklone#200.
BenoitPerrot
pushed a commit
to criteo-forks/private-bower
that referenced
this issue
Nov 19, 2015
Several options of git/svn daemons are not expecting any value,
and no "=" should be appended to the mnemonic when used.
Note that the way to identify such a parameter is tricky and
debatable. The choice made here is to consider empty strings as a
marker for unvalued parameters. To give an actual empty string to
a parameter, a string with a space can still be used.
For example the following configuration:
{
...
"repositoryCache": {
"git": {
"foo": " "
"verbose": "",
"syslog": "",
"max-connections": 42
}
}
}
Would make private-bower invoke the git daemon as follows:
git-daemon --foo= --verbose --syslog --max-connections=42
(Notice the two spaces after "--foo=", effectively giving an empty
value to the "foo" parameter)
Fixes Hacklone#200.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Several options of git/svn daemons are not expecting any value, and no "=" should be appended to the mnemonic when used. As of today, it is not possible to specify unvalued parameters in the private-bower configuration for these daemons.
Quite notably the options controlling the logging of git-daemon ("--verbose" and "--syslog") cannot be set in the configuration.
I will push a merge request fixing the issue.
The text was updated successfully, but these errors were encountered: