Skip to content

Fix read thread access of class consts lookup rendering #2438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025
Merged

Fix read thread access of class consts lookup rendering #2438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions ...drienbrault/idea/symfony2plugin/completion/lookup/ClassConstantLookupElementAbstract.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,15 @@
* @author Daniel Espendiller <daniel@espendiller.net>
*/
abstract public class ClassConstantLookupElementAbstract extends LookupElement implements ClassConstantInsertHandler.ClassConstantLookupElementInterface {

@NotNull
protected final PhpClass phpClass;

@NotNull
String phpClassName;

public ClassConstantLookupElementAbstract(@NotNull PhpClass phpClass) {
this.phpClass = phpClass;
this.phpClassName = phpClass.getName();
}

@Override
Expand All @@ -30,7 +33,7 @@ public void renderElement(LookupElementPresentation presentation) {
@NotNull
@Override
public String getLookupString() {
return phpClass.getName();
return this.phpClassName;
}

@NotNull
Expand All @@ -45,7 +48,7 @@ public PhpClass getPhpClass() {
}

@Override
public void handleInsert(InsertionContext context) {
public void handleInsert(@NotNull InsertionContext context) {
ClassConstantInsertHandler.getInstance().handleInsert(context, this);
}
}