Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: explicitly specify default arg for pydantic Fields #255

Merged
merged 1 commit into from
Sep 21, 2024
Merged

fix: explicitly specify default arg for pydantic Fields #255

merged 1 commit into from
Sep 21, 2024

Conversation

tazlin
Copy link
Member

@tazlin tazlin commented Sep 21, 2024

@tazlin
fix: explicitly specify default arg for pydantic Fields
cc75d63 
Either the behavior changed at some point or I overlooked the fact that the `default` arg is not propagated through to mypy properly if it is specified positionally. This makes it explicit in all cases to fix the bug, if there is one, and at the very least least clarifies the meaning of the argument.
@tazlin tazlin added the release:patch Version _._.x label Sep 21, 2024
@tazlin tazlin merged commit 3e705dc into releases Sep 21, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release:patch Version _._.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tazlin