Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1077: Added support of Python3 on top of Python 2.7 #1078

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

#1077: Added support of Python3 on top of Python 2.7 #1078

wants to merge 2 commits into from

Conversation

jfthuong
Copy link

Summary of changes:

  • Upgraded depencies on Python to support both Python 2.7 and Python 3

Regressions to look for:

  • None

Completed checkin tasks:

  • Updated changelog/public/latest.json.

@jfthuong
Copy link
Author

Python2 is still needed for the current version of node-gyp listed in package.json.

andrewnc
andrewnc approved these changes May 13, 2022
View reviewed changes
Copy link

@andrewnc andrewnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes all look good to me! Have you been able to test pushing with them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewnc andrewnc andrewnc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfthuong @andrewnc