Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added null-check for buffer extraction procedure #1391

Merged
merged 2 commits into from
Jul 24, 2020
Merged

Added null-check for buffer extraction procedure #1391

merged 2 commits into from
Jul 24, 2020

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Jul 1, 2020

Fixes #1336

@ethouris ethouris requested a review from maxsharabayko July 1, 2020 13:08
@ethouris ethouris self-assigned this Jul 1, 2020
@ethouris ethouris added [core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code labels Jul 1, 2020
@ethouris ethouris added this to the v1.5.0 - Sprint 19 milestone Jul 1, 2020
maxsharabayko
maxsharabayko requested changes Jul 13, 2020
View reviewed changes
srtcore/buffer.cpp Outdated Show resolved Hide resolved
srtcore/buffer.cpp Outdated Show resolved Hide resolved
srtcore/buffer.cpp Outdated Show resolved Hide resolved
@maxsharabayko maxsharabayko merged commit 89902fb into Haivision:master Jul 24, 2020
@mbakholdina mbakholdina modified the milestones: v1.5.0 - Sprint 19, v1.4.2 Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxsharabayko maxsharabayko maxsharabayko approved these changes

Assignees

@ethouris ethouris

Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.4.2
Development

Successfully merging this pull request may close these issues.

[MAINT] Writing from buffer to a file raises question of potential NULL pointer reading
3 participants
@ethouris @maxsharabayko @mbakholdina