Restored old behavior when parties declare encryption differently. #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The so far behavior with HSv5 was such that if parties declare encryption differently (which is the same with wrong password, as well as only one side declares encryption), the connection was rejected.
This fix makes the connection accepted also under this condition, and additionally the side that declares no encryption is still capable of sending the - unencrypted, obviously - data. Sending the data is also accepted, if a party declares encryption, and its peer does not or sets wrong password, just the receiver is unable to retrieve anything.