-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Fixed problem with handling the lingering links case in non-blocking group reader #1835
Conversation
…for found locking problems.
This remains as draft due to enclosing two different solutions. The fix for wrong lock on |
why not merge this pr? |
I remerged this with latest upstream; the fix for the deadlock on ConnectionLock is already merged. The remaining thing is the avoidance of the spurious read-ready for group. |
Note that I have doubts about the provided solution mainly because this newly introduced flag seems to be required to be filled from a separate thread, so likely this field should be atomic. There's another PR that provides atomic and should be cleared first. |
Great, I found your atomic PR is merged, so this PR is unblocked now?
The remaining part I care is just |
Closed by #2203 |
The problem is described in #1805, though may need further testing.
This PR also contains a fix for lock ordering at the handshake, might need to be moved.