-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] use seq larger than m_RcvBaseSeqNo to update group readablity #2026
[core] use seq larger than m_RcvBaseSeqNo to update group readablity #2026
Conversation
…up readablity in tsbpd mode
For example, in this log https://1drv.ms/u/s!AuaosNlJ5ELxjy_WjKk1fnymnYGY?e=s8hn0F
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are providing the base seqno of the group's reading position to the receiver buffer when reading a packet.
If there is a packet ready to be read, but it is behind the group's base, it is just skipped (and the memory unit is freed).
Then in one call, the buffer can try to read the next packet for a group, instead of reading the first available packet in the buffer (which was already read from another socket), and waiting for another notification for read-readiness.
exactly, if the another socket is disconnected, then this socket (the first ready-to-play packet is smaller than group_base) will never get a chance to make group readable |
address comments Co-authored-by: Maxim Sharabayko <maxlovic@gmail.com>
Fix the issue memtioned in #1805 (comment)