Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Added a note on activating HAICRYPT logging #2529

Merged
merged 4 commits into from
Nov 14, 2022

Conversation

maxsharabayko
Copy link
Collaborator

As I always have to spend 5-10 minutes to find out how to activate the HAICRYPT logging, I thought it would be helpful to have it in our docs.

@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [docs] Area: Improvements or additions to documentation labels Nov 11, 2022
@maxsharabayko maxsharabayko added this to the v1.6.0 milestone Nov 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2022

Codecov Report

Merging #2529 (6fd317b) into master (cbfa812) will increase coverage by 0.53%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2529      +/-   ##
==========================================
+ Coverage   64.82%   65.36%   +0.53%     
==========================================
  Files         100      100              
  Lines       19767    19767              
==========================================
+ Hits        12814    12920     +106     
+ Misses       6953     6847     -106     
Impacted Files Coverage Δ
srtcore/buffer_snd.cpp 67.10% <0.00%> (-0.66%) ⬇️
test/test_bonding.cpp 93.68% <0.00%> (-0.53%) ⬇️
srtcore/buffer_rcv.cpp 58.44% <0.00%> (-0.39%) ⬇️
srtcore/core.cpp 59.93% <0.00%> (+0.58%) ⬆️
srtcore/queue.cpp 81.34% <0.00%> (+0.74%) ⬆️
srtcore/window.cpp 83.11% <0.00%> (+1.29%) ⬆️
srtcore/api.cpp 54.92% <0.00%> (+1.69%) ⬆️
srtcore/cache.h 83.07% <0.00%> (+3.07%) ⬆️
srtcore/list.cpp 82.11% <0.00%> (+12.73%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@stevomatthews stevomatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits

Co-authored-by: stevomatthews <smatthews@haivision.com>
@maxsharabayko maxsharabayko merged commit 89992c0 into Haivision:master Nov 14, 2022
@maxsharabayko maxsharabayko deleted the docs/haicrypt-log branch November 14, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[docs] Area: Improvements or additions to documentation Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants