[test] Added yielding for tests that spawn a thread for connect #2883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethouris
added
Type: Maintenance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2883 +/- ##
==========================================
+ Coverage 64.26% 64.52% +0.26%
==========================================
Files 101 101
Lines 17480 17490 +10
==========================================
+ Hits 11233 11285 +52
+ Misses 6247 6205 -42 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem: although the call of
srt_accept_bondis given 2s timeout, it may still happen to not be enough, especially when testing on a weak, loaded machine.Added the call to
this_thread::yield()to make the thread switched to the spawned one so that it can at least start calling thesrt_connectmethod beforesrt_accept_bond()is going to pick it up. This should help with falsely failing tests in Travis.