-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix build issue when configure --enable-testing #2948
Conversation
Isn't it declared that if |
I don't know, here is the output from my configure and make, maybe I'm doing something wrong:
|
But that part of the code is blocked by a conditional macro, which is not enabled by default. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2948 +/- ##
==========================================
+ Coverage 64.88% 65.25% +0.37%
==========================================
Files 101 101
Lines 17634 17634
==========================================
+ Hits 11441 11507 +66
+ Misses 6193 6127 -66 ☔ View full report in Codecov by Sentry. |
make fails when ./confgure --enable-testing
/home/build/srt_kageds/srtcore/group.cpp: In member function ‘void srt::StabilityTracer::create_file()’: /home/build/srt_kageds/srtcore/group.cpp:2577:46: error: no matching function for call to ‘std::basic_ofstream<char>::open(const string&, const openmode&)’ m_fout.open(fname, std::ofstream::out); ^ /home/build/srt_kageds/srtcore/group.cpp:2577:46: note: candidate is: In file included from /home/build/srt_kageds/srtcore/udt.h:86:0, from /home/build/srt_kageds/srtcore/api.h:60, from /home/build/srt_kageds/srtcore/group.cpp:5: /usr/include/c++/4.8.2/fstream:713:7: note: void std::basic_ofstream<_CharT, _Traits>::open(const char*, std::ios_base::openmode) [with _CharT = char; _Traits = std::char_traits<char>; std::ios_base::openmode = std::_Ios_Openmode] open(const char* __s, ^ /usr/include/c++/4.8.2/fstream:713:7: note: no known conversion for argument 1 from ‘const string {aka const std::basic_string<char>}’ to ‘const char*’ make[2]: *** [CMakeFiles/srt_virtual.dir/srtcore/group.cpp.o] Error 1 make[1]: *** [CMakeFiles/srt_virtual.dir/all] Error 2 make: *** [all] Error 2