-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core][API] Obtaining local interfaces to allow getting connected device name #2989
Draft
ethouris
wants to merge
34
commits into
Haivision:master
Choose a base branch
from
ethouris:dev-add-obtaining-network-id
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+239
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vention' into dev-add-obtaining-network-id
… connected socket
Problem: I turned this option on on the C++11/Windows CI workflow and it results in a linker error for this newly introduced function. Strange at least, and likely it needs some Windows linker trick to function. |
maxsharabayko
added
Type: Enhancement
Indicates new feature requests
[core]
Area: Changes in SRT library core
[API]
Area: Changes in SRT library API
labels
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[API]
Area: Changes in SRT library API
[core]
Area: Changes in SRT library core
Type: Enhancement
Indicates new feature requests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially restores the recognition facility as provided in #377 and uses it to obtain the device name.
This introduces an internal function
GetLocalInterfaces()
, which is in use by applications and for internal purposes, and a new API function,srt_getsockdevname
, which extracts the device name of the connected socket. This is also in use by a testing application so that the connected status is displayed in Verbose mode.Note that it doesn't have a guaranteed working in every case. So far it is tested on:
{UUID}
, also if the device being used is VPN.srt_getsockname
seems to be the VPN-assigned local name, but it is not present in the results ofGetLocalInterfaces()
.