Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Try winpthread before pthreadGC2 #429

Merged
merged 1 commit into from
Jul 17, 2018
Merged

Conversation

ocrete
Copy link
Contributor

@ocrete ocrete commented Jul 16, 2018

It seems that pthreadGC2 is deprecated and it should prefer
winpthread. Also remove all of the commented out stuff.

The set() call seems to be superfluous with the find_library() calls. VLC had to change the "-lpthreadGC" to "-lpthread" in their build.

It seems that pthreadGC2 is deprecated and it should prefer
winpthread. Also remove all of the commented out stuff.
@ethouris
Copy link
Collaborator

BTW. is there any "official" pthread implementation for Windows? This Pthread-win32 for which information is attached to the repo I just found as something that can seal the hole, but if there's something more official, which doesn't need to refer to a "volatile" Github project, it would be much better.

BTW. I see a removed set and comment, but no attempt to find winpthreads. Is it this?

https://github.com/ldx/winpthreads

@ocrete
Copy link
Contributor Author

ocrete commented Jul 17, 2018

@ethouris
Copy link
Collaborator

I know. I just think it would be nice to find some reliable method of having some "more reliable" pthread implementation for Windows, used not only for MinGW, but also for a case defined in the cmake as MICROSOFT. Unless Microsoft has provided already something better that I'm not aware of.

@rndi rndi merged commit 9711665 into Haivision:master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants