Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added information about maximum payload size #459

Merged
merged 2 commits into from
Feb 14, 2019

Conversation

ethouris
Copy link
Collaborator

People get often confused about the maximum payload size in SRT when trying to send RTP over SRT; this could be at least as a reference information what to be aware of in this case.

@jeandube
Copy link
Collaborator

Earlier versions of SRT had a default MSS of 1500 bytes and it has never been a subject of discussion.

@ethouris
Copy link
Collaborator Author

This is still in force, but doesn't tell the user much about how much is the size of a payload.

@ethouris ethouris added Priority: High Type: Maintenance Work required to maintain or clean up the code Status: In Progress labels Jan 21, 2019
@maxsharabayko
Copy link
Collaborator

v.1.2.3 also has a payload size of 1316 bytes.
Please consider adding a reference to the constants SRT_LIVE_DEF_PLSIZE and SRT_LIVE_MAX_PLSIZE of srt.h to the doc file.

@maxsharabayko maxsharabayko added this to the v.1.3.2 milestone Jan 21, 2019
@maxsharabayko maxsharabayko added [docs] Area: Improvements or additions to documentation and removed Status: In Progress Type: Maintenance Work required to maintain or clean up the code labels Jan 30, 2019
@@ -24,7 +24,10 @@ transport unit size for SRT, and it is also often used when sending MPEG-TS over
Note that SRT isn't limited to MPEG-TS -- it can be applied to any "live streaming" data
transmission (as long as you use Live mode, which is the SRT default mode). You can use
any other suitable data format, and any intermediate protocol on top of MPEG-TS with
an extra header (you still have an extra 140 bytes per unit for that purpose).
an extra header (if you want to do this - as people often try this with RTP - note
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
an extra header (if you want to do this - as people often try this with RTP - note
an extra header (this is an option that people often try with RTP) - note

@@ -24,7 +24,10 @@ transport unit size for SRT, and it is also often used when sending MPEG-TS over
Note that SRT isn't limited to MPEG-TS -- it can be applied to any "live streaming" data
transmission (as long as you use Live mode, which is the SRT default mode). You can use
any other suitable data format, and any intermediate protocol on top of MPEG-TS with
an extra header (you still have an extra 140 bytes per unit for that purpose).
an extra header (if you want to do this - as people often try this with RTP - note
that 1316 is the default maximum payload size, which can be changed using
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
that 1316 is the default maximum payload size, which can be changed using
that 1316 is the default maximum payload size, which can be changed using the

@rndi rndi merged commit 4e59464 into Haivision:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[docs] Area: Improvements or additions to documentation Priority: High
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants