Made WinSock non-blocking #383 #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we set the minimum recv timeout to 1ms on Windows, but there is an undocumented minimum receive timeout of 500ms, according to some sources online. As a result, some packets were lost for srt, but were still received by wireshark. This commit sets the socket to non-blocking via ioctl
maxsharabayko
added a commit
to maxsharabayko/srt
that referenced
this pull request
Dec 5, 2018
This fixes the high CPU load issue on Windows with non-blocking sockets (after PR Haivision#483). Fixed type casting warnings in channel.cpp.
maxsharabayko
added a commit
to maxsharabayko/srt
that referenced
this pull request
Dec 5, 2018
This fixes the high CPU load issue on Windows with non-blocking sockets (after PR Haivision#483). Fixed type casting warnings in channel.cpp.
maxsharabayko
added a commit
to maxsharabayko/srt
that referenced
this pull request
Dec 5, 2018
This fixes the high CPU load issue on Windows with non-blocking sockets (after PR Haivision#483). Fixed type casting warnings in channel.cpp.
maxsharabayko
added a commit
to maxsharabayko/srt
that referenced
this pull request
Dec 5, 2018
This fixes the high CPU load issue on Windows with non-blocking sockets (after PR Haivision#483). Fixed type casting warnings in channel.cpp.
rndi
pushed a commit
that referenced
this pull request
Dec 7, 2018
This fixes the high CPU load issue on Windows with non-blocking sockets (after PR #483). Fixed type casting warnings in channel.cpp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we set the minimum recv timeout to 1ms on Windows, but there is an undocumented minimum receive timeout of 500ms, according to some sources online1 a result, some packets were lost for srt, but were still received by wireshark. This commit sets the socket to non-blocking via ioctl, which causes all packets to be correctly received.