Putting global objects with short names under a namespace #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 14, 2019 13:01
…ds using std::string during initialization time.
rndi
suggested changes
Feb 15, 2019
rndi
reviewed
Feb 15, 2019
srtcore/logging.h
Outdated
|
|
||
| // If the size of the FA name together with severity exceeds the size, | ||
| // just skip the former. | ||
| if (logger_pfx && strlen(prefix) + strlen(logger_pfx) < MAX_PREFIX_SIZE) |
rndi
reviewed
Feb 15, 2019
rndi
reviewed
Feb 15, 2019
srtcore/logging.h
Outdated
| src_config(&config) | ||
| { | ||
| // XXX stpcpy desired, but not enough portable | ||
| // Composing the exact prefix is not critical, so simply | ||
| // cut the prefix, if the lenght is exceeded |
rndi
approved these changes
Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix provides the following changes:
loggingnamespace. This should keep away any name conflicts with other libraries. This exactly case was believed to cause problems when added to ffmpeg linked to OBS Studio.bloglogger is commented out (it was the one caught with suspected name conflict). This isn't in use, but it was commented out just so that the existing FA can be reused for something else in future.std::stringwas removed from the initialization of the global objects. Although it wasn't causing problems with building OBS Studio, as it was initially suspected, keeping the solution using only C standard library keeps it safe against any future problems concerning the order of initialization.