Set metadata in SRT DLL on Windows #639
Conversation
* -add x86 compile to appveyor build for win * -tune the way VS SLN gets platform value * -make use of quotes consistent in appveyor * -factor bitness into folder names for libs * -add 64bit hint for pthread_include_dir * -add bitness to artifact name * -add VS_VERSION to artifact name * -gather PDB for debug builds * -set more sensible build number in appveyor
-remove vs2013 hangovers -add .gitingore extras -stop pthreads going into built package zip
-srt static library DLL on windows now has file version and copyright metadata set
…rshell" This reverts commit c938c3e.
This reverts commit 201dc70.
|
Please resolve Travis CI build errors. Compiler: x86_64-w64-mingw32-g++ C++ |
-no win metadata attached to Cygwin
|
Sorry I took so long to come back to this. I have now merged master (resolves conflicts) and put in the small tweak to stop any of the Windows metadata being assigned during CYGWIN builds. |
-adjust cmake to ask for var pointing at pthreads if not found by glob
ethouris
added
Status: Completed
Type: Maintenance
There was a problem hiding this comment.
Please remove (again) googletest submodule, it was re-added in commit 5208f83. In the future, please consider re-organizing your PRs into meaningful commits with interactive rebase or, otherwise, squashing them into a single commit. Thanks!
This is fixed - I'm in contact with @maxlovic about a separate PR that will then move the build to a sub-folder in the build, and then the .gitignore can cover this. I have also learned a lot about workflows for PRs, and will try to avoid such a long, messy trail in the future. |
This PR shows changes to automated metadata against the SRT DLL created during CI builds.
Unfortunately, it builds upon the Windows build changes in another PR, so it looks a little more cluttered until that is merged. However, this PR allows inspection of the proposed change.The key file is srt_shared.rc, which is used during compilation to set the metadata. CMakeLists is changed to pick up the build number from CI and pass into the version header used at compile to ident the binaries.
The windows DLL is also marked as 'delay load' in this PR, which means it will run happily without any Open SSL dependencies being available (calls to dependent functions will obviously fail) - which is useful if someone has restrictions on making Open SSL available in their usage.
Probably this PR should be revised regarding the 'copyright' name - I have no objection to it just being set to Haivision, but maybe others might - it's not my call. But it's probably better to try and face this sooner rather than later... however, i'm also perfectly fine with that field being deleted rather than it hold up the PR!Copyright value is now just empty, because empty is not a change and therefore not controversial. I don't want to hold up this PR by having some long debate about what the value should be - I defer setting this to someone from Haivision!This PR now also automates the AppVeyor build number, drawing the source values from the master value set centrally. It also marks the resulting DLLs with the git repo name, along with the branch / commit numbers in the 'File Description' property of the DLL - allowing easy tracing of origin - see here:
It might make sense to also close this PR once reviewed and then re-issue when PR614 gets merged.