-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for configuring connection response timeout #719
Add option for configuring connection response timeout #719
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to add two characters, to make the naming more obvious.
rsptimeo
-> rsptimeout
SRTO_RSPTIMEO
-> SRTO_RSPTIMEOUT
This is actually an inactivity timeout. RSPTIMEOUT may be confused with the existing RCVTIMEO, Regarding TIMEO vs. TIMEOUT I think the initial proposal was for consistency with the other timeout options (SNDTIMEO, RCVTIMEO, CONNTIMEO). It is a choice of consistency vs. clarity. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@jeandube your decision. |
@maxlovic Everything is fine with me. |
New option:
SRTO_RSPTIMEO
allows to configure "response time", that is, the longest tolerable time during which agent receives no packets from peer. Upon passing of this time the connection is considered broken.