Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for configuring connection response timeout #719

Merged
merged 3 commits into from
Jun 10, 2019

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Jun 3, 2019

New option: SRTO_RSPTIMEO allows to configure "response time", that is, the longest tolerable time during which agent receives no packets from peer. Upon passing of this time the connection is considered broken.

@ethouris ethouris added this to the v.1.3.3 milestone Jun 3, 2019
@ethouris ethouris added [core] Area: Changes in SRT library core Type: Enhancement Indicates new feature requests labels Jun 3, 2019
Copy link
Collaborator

@maxsharabayko maxsharabayko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to add two characters, to make the naming more obvious.
rsptimeo -> rsptimeout
SRTO_RSPTIMEO -> SRTO_RSPTIMEOUT

@jeandube
Copy link
Collaborator

jeandube commented Jun 3, 2019

This is actually an inactivity timeout. RSPTIMEOUT may be confused with the existing RCVTIMEO, Regarding TIMEO vs. TIMEOUT I think the initial proposal was for consistency with the other timeout options (SNDTIMEO, RCVTIMEO, CONNTIMEO). It is a choice of consistency vs. clarity.

@ethouris ethouris requested a review from maxsharabayko June 4, 2019 15:12
@maxsharabayko
Copy link
Collaborator

  • Add this new option to API.md

Copy link
Collaborator

@maxsharabayko maxsharabayko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@maxsharabayko
Copy link
Collaborator

@jeandube your decision.

@jeandube
Copy link
Collaborator

jeandube commented Jun 5, 2019

@maxlovic Everything is fine with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants