UriParser improvements

[AdeMiller]

• Make property accessors const.
• Proto is converted to lower case. The current code assumes a lowercase
  proto and will fail if the input is not lowercase.
• Type now supports all existing types.
• Type RTP added.
• Test code no longer crashes when called with no args.
• Fixed layout removing extraneous empty lines.

[ethouris]

@AdeMiller : I was kinda surprised that this call with std::transform works; I had problem once that was caused by having two overloaded versions of ::tolower, with one extra definition for the sake of locales. Nice if you check if this still gets compiled if you add #include <locale> in the beginning of the file. Might be that it needs an explicit specification of kinda wrapper struct ToLower { char operator()(char c) { return ::tolower(c); } };. Unfortunately in C++ some headers might be included on a whim by particular compiler, changing the rules this way.

Otherwise, beside these braces, I have no more comments.

[AdeMiller]

@AdeMiller : I was kinda surprised that this call with std::transform works; I had problem once that was caused by having two overloaded versions of ::tolower, with one extra definition for the sake of locales. Nice if you check if this still gets compiled if you add #include <locale> in the beginning of the file. Might be that it needs an explicit specification of kinda wrapper struct ToLower { char operator()(char c) { return ::tolower(c); } };. Unfortunately in C++ some headers might be included on a whim by particular compiler, changing the rules this way.

Otherwise, beside these braces, I have no more comments.

So I did some investigation around this ::tolower forces the outermost namespace so works fine with an include like locale. However if the code references std::tolower then including locale will cause compilation errors in exactly the way you describe. It seems like the most robust fix for this would be to explicitly reference the STL function from within a lambda

        transform(m_proto.begin(), m_proto.end(), m_proto.begin(), [](char c){ return std::toupper(c); });

I've changed the code accordingly.

[ethouris]

Please update according to the comments.