close Channel after stopping recv send queues #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Channel is used by recv and send queues and possible blocked in I/O operations. Closing the channel while it is still in use causes problems with the recv and send queues and may cause problems in other threads of the application.
|
This is for issue #306 |
maxsharabayko
approved these changes
Aug 12, 2019
There was a problem hiding this comment.
m_pChannel->close() closes the system socket, while it might still be used somewhere.
A worker thread of the sender can be calling sendto on the channel. And there is no mutex around it. So nothing stops the channel to close the socket in another thread, causing the error.
Deleting both queues ensures the socket is not used anymore. Also the destructor of the sender calls m_pTimer->interrupt();, interrupting ongoing waits for the state changes.
maxsharabayko
added
the
Type: Bug
rndi
approved these changes
Aug 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Channel is used by recv and send queues and possible blocked in I/O
operations. Closing the channel while it is still in use causes
problems with the recv and send queues and may cause problems in other
threads of the application.
Fixes #306.