Add GET for SRTO_LOSSMAXTTL #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
the
Type: Maintenance
maxsharabayko
force-pushed
the
develop/getopt-reorder-tolerance
branch
from
a4d1f4c to
981a718
Compare
ethouris
reviewed
Oct 30, 2019
There was a problem hiding this comment.
I don't see any sense made by a test that tests an option that is bound to a field in CUDT class. There's something about 50 such options in the whole SRT and just one is being tested? If you could select all such options for which this rule is applicable and add them to a common procedure, this would make much more sense.
|
I understand. Still, I think the idea of extending all options that are readable and of PRE type could have this kind of test added as well - possibly as a separate PR. |
maxsharabayko
force-pushed
the
develop/getopt-reorder-tolerance
branch
from
981a718 to
76993fd
Compare
ethouris
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
srt_getopt(...):optlenis not set in some cases.SRTO_LOSSMAXTTLtosrt_getopt()SRTO_LOSSMAXTTL. Checks issue srt-live-transmit - strange behaviour with jitter #735.