Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated Conquest mission to new mission framework #3

Merged
merged 5 commits into from
Jul 3, 2022

Conversation

msyulia
Copy link

@msyulia msyulia commented Jul 3, 2022

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Migrated the conquest outposts mission to the new task framework.
Included factories and seaports as valid mission objectives for this mission.

Please specify which Issue this PR Resolves.

N/A

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

Steps:

  • execute [["CON"]] call A3A_fnc_requesttask as local
  • complete the mission by flipping the flag or issuing proper debug command

Notes:

Copy link
Owner

@HakonRydland HakonRydland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HakonRydland HakonRydland merged commit cc99c1a into HakonRydland:TaskFramework Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants