Integrate HXE's SFX library, replacing the use of WinRAR to create releases. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add reference to HXE for AmaiSosu.GUI Solution Update Copyright info Bump versions to 0.4.3
There's no need to reinvent the wheel at this point in time.
Remove old --auto codepath.
Tweak Context.Infer() to allow three possibilities: Compile, Help, and default to Install. Add Compile UserControl. Add Install UserControl. Name the Grid and StackPanel elements in MainWindow.
Rename Compile and Install UserControls. Create instances of each UserControl in the MainWindow.
Rename AmaiSosu.GUI.MainInstall.Install() to AmaiSosu.GUI.Install.Invoke()
Move Startup out of AmaiSosu.Main to AmaiSosu.Startup. Fix UserControl.Install.xaml's indentation.
Re-attempt getting DataContext bindings working.
- Main's UserControl instances aren't needed; only the underlying DataContext Bindings. - Now that the UserControls' DataContexts are set in the MainWindow.xaml, we don't need them in Main.cs - Move Contextual work to the Main class. - Tweak nearly every binding in a desparate attempt to get them to work. - In Compile and Install UserControls, brute-force past the DataContext NullReference issue by overwriting it anyway.
fix: DataContexts are now assigned to local instances of relevant classes in MainWindow rather than in their UserControls.
One curly bracket...
…for packaging. Incidentally, this deprecates the AmaiSosu.Common.Package class.
Bootstrap .NET Framework 4.6.1
refactor(Install): Move existing Kornner Studios directory to backup directory
refactor: Change HXE.SFX and AmaiSosu.Common.Paths references to use "using x = namepace.x" Usings convention. 1. Keeping the namespace prefixes in member accessors should clarify where certain variables are declared and defined. We don't do this for the System namespace unless necessary. 2. This definitive Usings convention will help prevent unused namespaces and classes from overlapping which could lead to ambiguous references during development.
refactor(Compile): Remove old, temporary code
refactor: Remove PackageFactory's unused "_selection" variable.
It was required to package OpenSauce, but that file isn't present in any previous releases. Why did I add in the first place?
…n.Installer classes to AmaiSosu.Core namespace refactor: Rename PackageFactory's Installation Path parameters to 'path' refactor: remove unnecessary Using from AmaiSosu.Startup
… location fix: Package Verification no longer checks if the Path parameter is an existing Directory
…isting Directory.
… will include the Packages directory when needed. refactor(Install): Remove redundant deletion of Kornner Studios directory
…stall.CommitBackups()
…tallation or Compilation
…p until successful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1
Resolves #4
Milestone b46db60 is fully functional, but lacks certain features and relies on code that has no business being in AmaiSosu.GUI
TODO:
Nearly done. Needs testing.
Install: Fix "clean up backup directory".Working as intended; only deletes backupDir if empty.Install: Add checkbox (default: checked) to delete/cleanup extracted files afterward.Always delete Temp dir.Display HXE's console output in AmaiSosu.GUI. It needs to be copied to AmaiSosu.GUI AND a standard console output so the output can still be displayed or caught if the GUI is skipped with "--auto".Moved to issue Catch and display console output in AmaiSosu's GUI #7 .Merge PackageFactory's "GetInstaller" and "GetCompiler"Not worth the effort.