fix width and height of cfp form #205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
-
Everything we do on the Hebrew version, we should do on the English version of the page too (under en/)
-
We need to test in desktop and various mobiles - to verify that it actually improves.
To test how it looks, you can use the following sample:
https://amit-public.s3.eu-west-1.amazonaws.com/ap2023_samples/moshe_resize_1_index.html
index.html
Outdated
| @@ -90,7 +90,7 @@ <h1 class="noMobile"> | |||
| <div> | |||
| רוצים לתת חסות? צרו קשר עם <a href="mailto:board@hamakor.org.il">board@hamakor.org.il</a> | |||
| </div> | |||
| <iframe src="https://docs.google.com/forms/d/e/1FAIpQLScQwZkPa0lLdbFEG5Ek3XuzEd2oeoe6Ca_bOCP4aWp_0npZRw/viewform" width="640" height="2500"></iframe> | |||
| <iframe src="https://docs.google.com/forms/d/e/1FAIpQLScQwZkPa0lLdbFEG5Ek3XuzEd2oeoe6Ca_bOCP4aWp_0npZRw/viewform" width="480" height="1600"></iframe> | |||
There was a problem hiding this comment.
On my phone at least, in "portrait mode", the form is still cut off to the side (too wide), so does not improve the visibility.
And in desktop mode the original width looks much better.
(on phone "landscape mode" (rotated to the side), both look OK)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.