Skip to content

Commit

Permalink
Merge pull request plotly#903 from plotly/import-test
Browse files Browse the repository at this point in the history
improve dash import test
  • Loading branch information
alexcjohnson committed Dec 10, 2020
1 parent 7cac1c9 commit 0e9eb9c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 9 deletions.
4 changes: 4 additions & 0 deletions packages/dash-core-components/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [UNRELEASED]
### Fixed
- [#903](https://github.com/plotly/dash-core-components/pull/903) - part of fixing dash import bug https://github.com/plotly/dash/issues/1143

## [1.14.1] - 2020-12-09
### Updated
- [#898](https://github.com/plotly/dash-core-components/pull/898)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,11 @@
__version__ = package['version']

# Module imports trigger a dash.development import, need to check this first
if not hasattr(_dash, 'development'):
if not hasattr(_dash, '__plotly_dash') and not hasattr(_dash, 'development'):
print("Dash was not successfully imported. Make sure you don't have a file "
"named \n'dash.py' in your current directory.", file=_sys.stderr)
_sys.exit(1)

# Must update to dash>=0.23.1 to use this version of dash-core-components
if not hasattr(_dash.development.base_component, '_explicitize_args'):
print("Please update the `dash` module to >= 0.23.1 to use this "
"version of dash_core_components.\n"
"You are using version {:s}".format(_dash.version.__version__),
file=_sys.stderr)
_sys.exit(1)

from ._imports_ import * # noqa: F401, F403
from ._imports_ import __all__ # noqa: E402

Expand Down

0 comments on commit 0e9eb9c

Please sign in to comment.