Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error handling when Tariff data unavailable & other minor enhancements. #80

Closed
wants to merge 12 commits into from

Conversation

ColinRobbins
Copy link
Contributor

Description

This PR contains the following enhancements:

  • If Tariff data is unavailable (as indicated as a failure to ever retrieve data), rather than retry every 2 minutes (which will repeatedly fail), it backs off to trying once per day.
  • If Tariff data is temporarily unavailable (indicated by data having been previously been retrieved), there is no change to behaviour.
  • When data is not available the sensor status is set to "unavailable" instead of "unknown".
  • Reading the Tariff rate data waits for 2 seconds to allow the data to arrive from the buddy Standing Rate sensor. Without this the Tariff rate data is always one update cycle out of date (2 minutes),

Motivation and Context

Enhancements

How Has This Been Tested?

Run in local test and live environment.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@Bod1985
Copy link

Bod1985 commented Jan 6, 2022

Any news on this? My tariff doesn’t seem to be available in the Bright app and thus also not available in the integration

@ColinRobbins
Copy link
Contributor Author

No, no news @HandyHat has gone silent for a while.
In any case, if the data is not showing in Bright, all this PR will do is better error handling. The real solution is to get your energy provider to fix the issue.

@HandyHat
Copy link
Owner

HandyHat commented Jan 6, 2022

Apologies - been having some issues with my Home Assistant instance which means I haven't been able to locally test this. Will have a look soon!

@ColinRobbins
Copy link
Contributor Author

To be replace with a roll up...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants