Includegraphics resiliency and file extension case de-sensitivity

[jojo2357]

Fix #3142

Added jpeg, and allow JPG, JPg and such to be valid.

Why though, does

TeXiFy-IDEA/src/nl/hannahsten/texifyidea/lang/commands/RequiredFileArgument.kt

Lines 72 to 78 in cea8254

	override fun matchesName(fileName: String): Boolean {
	return pattern!!.matcher(fileName.lowercase(Locale.getDefault())).matches()
	}
	override fun matchesExtension(extension: String): Boolean {
	return supportedExtensions.contains(extension)
	}

have zero usages?

I have no idea how to use the already implemented commands, so i did some jank in order to get it to work, please fix
https://github.com/jojo2357/TeXiFy-IDEA/blob/a15853ff8736c5b434546edb677cbe8c50affacf/src/nl/hannahsten/texifyidea/reference/InputFileReference.kt#L169

[PHPirates]

According to https://tex.stackexchange.com/questions/469734/which-file-does-includegraphics-select-if-there-are-multiple-files-with-differen \includegraphics just tries a list of extensions one by one. Why not do that as well (extending the hardcoded list), instead of this case insensitivity mess?

[jojo2357]

Oh yes please.

Hence why i made only a draft pr.

What if we made it tell you specifically that an extension is not valid (instead of file.pdf is missing) and also a warning when multiple candidates are found (ex all of .png .jpg etc exist)?

Maybe thats beyond the scope of this issue but it sounds like a cool feature.

[jojo2357]

I pushed with great force, and now all that gross code is gone!

[PHPirates]

What if we made it tell you specifically that an extension is not valid (instead of file.pdf is missing) and also a warning when multiple candidates are found (ex all of .png .jpg etc exist)?

Maybe thats beyond the scope of this issue but it sounds like a cool feature.

Yeah we could make a 'maybe you meant this file instead' quickfix, that would be really nice.
But I don't think we even support \DeclareGraphicsExtensions yet, which sounds more important.

[jojo2357]

But I don't think we even support \DeclareGraphicsExtensions yet, which sounds more important.

That sounds out of the scope of this PR and while I agree, i think it should be covered in a separate pr

[jojo2357]

One test fails locally. LatexInclusionLoopInspectionTest#testIncludingPackage. Because all the extension stuff runs on lists, and tex comes before sty, there is no safeguard to specifically prefer sty in some cases.

[PHPirates]

One test fails locally. LatexInclusionLoopInspectionTest#testIncludingPackage. Because all the extension stuff runs on lists, and tex comes before sty, there is no safeguard to specifically prefer sty in some cases.

Exactly, so I switched the order

[PHPirates]

Looks good to me, thanks!

[jojo2357]

Merge?