Remove now unused API-tools system-packages profiles

With eclipse-pde#279 and
eclipse-pde#284 the users of those
profiles were changed to use better ways to find the available
system-packages of a Java version.

apitools/org.eclipse.pde.api.tools/build.properties

@@ -22,8 +22,7 @@ bin.includes = .,\
                META-INF/,\
                plugin.xml,\
                lib/apitooling-ant.jar,\
-               scripts/,\
-               system_packages/
+               scripts/
 jars.extra.classpath=platform:/plugin/org.apache.ant/lib/ant.jar,platform:/plugin/org.objectweb.asm
 jars.compile.order = .,\
                      lib/apitooling-ant.jar

apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/model/ApiBaseline.java

@@ -245,29 +245,20 @@ private void initialize(ExecutionEnvironmentDescription ee) throws CoreException
 		}
 	}
 
-
 	private static Properties getPropertiesFromURL(URL profileURL) {
-		InputStream is = null;
 		try {
 			URL resolvedURL = FileLocator.resolve(profileURL);
 			URLConnection openConnection = resolvedURL.openConnection();
 			openConnection.setUseCaches(false);
-			is = openConnection.getInputStream();
-			if (is != null) {
-				Properties profile = new Properties();
-				profile.load(is);
-				return profile;
-			}
-		} catch (IOException e) {
-			ApiPlugin.log(e);
-		} finally {
-			try {
+			try (InputStream is = openConnection.getInputStream()) {
 				if (is != null) {
-					is.close();
+					Properties profile = new Properties();
+					profile.load(is);
+					return profile;
 				}
-			} catch (IOException e) {
-				ApiPlugin.log(e);
 			}
+		} catch (IOException e) {
+			ApiPlugin.log(e);
 		}
 		return null;
 	}
@@ -302,11 +293,7 @@ public static Properties getJavaProfileProperties(String ee) {
 	private void initialize(Properties profile, ExecutionEnvironmentDescription description) throws CoreException {
 		String value = profile.getProperty(Constants.FRAMEWORK_SYSTEMPACKAGES);
 		if (value == null) {
-			// In Java-10 and beyond, we take systempackages list from
-			// org.eclipse.pde.api.tools\system_packages\JavaSE-x-systempackages.profile
-			// They are calculated by launching eclipse in Java x and then using
-			// org.eclipse.osgi.storage.Storage.calculateVMPackages
-			// Post Java 18 we use TargetPlatformHelper.querySystemPackages
+			// In Java-10 and beyond, we query system-packages list from the JRE
 			String environmentId = description.getProperty(ExecutionEnvironmentDescription.CLASS_LIB_LEVEL);
 			IExecutionEnvironmentsManager manager = JavaRuntime.getExecutionEnvironmentsManager();
 			IExecutionEnvironment environment = manager.getEnvironment(environmentId);