Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Names are not matching code conventions #29

Closed
Matix-Media opened this issue Mar 24, 2023 · 0 comments · Fixed by #30
Closed

Names are not matching code conventions #29

Matix-Media opened this issue Mar 24, 2023 · 0 comments · Fixed by #30
Assignees
@Matix-Media
Labels
enhancement New feature or request

Comments

@Matix-Media
Copy link
Collaborator

The naming of classes and types in the latest msmc is not correct. Mainly:

  • classes are currently in lower case, should be uppercase. E.g.: minecraft -> Minecraft
  • types are currently in lower case, should be uppercase. E.g.: mcToken -> McToken

References:

Discord forum post: https://discord.com/channels/861839919655944213/1087720321441878056
@Matix-Media Matix-Media self-assigned this Mar 24, 2023
@Matix-Media Matix-Media added the enhancement New feature or request label Mar 24, 2023
@Matix-Media Matix-Media mentioned this issue Mar 24, 2023
Merged
@Matix-Media Matix-Media linked a pull request Mar 24, 2023 that will close this issue
#29: names are not matching code conventions #30
Merged
Hanro50 added a commit that referenced this issue Mar 24, 2023
@Hanro50
Merge pull request #30 from Hanro50/29-names-are-not-matching-code-co…
ff43b90 
…nventions

#29: names are not matching code conventions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Matix-Media Matix-Media

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#29: names are not matching code conventions Hanro50/MSMC
1 participant
@Matix-Media