[regexp] Replace unicode property comparison instructions with generic set comparisons #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c set comparisons
Hans-Halverson
force-pushed
the
unicode-property-set
branch
from
7914be8 to
a5b7658
Compare
Hans-Halverson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In preparation for fixes to case insensitive mode we are moving some special comparison instructions to generic set comparisons. This PR refactors unicode property comparison instructions to use the generic set comparison path, meaning individual comparisons are emitted for each range in the set.
Unicode properties now implement an
add_to_setmethod instead of anis_matchmethod, which builds the set of code points corresponding to that property.Tests
Added RegExp bytecode snapshot tests for script and general category unicode properties, as well as complement classes. Verified that unicode property comparisons now use generic rang