Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to alias the profile name #29

Merged
merged 3 commits into from
May 24, 2024

Conversation

PascalFrenz
Copy link
Contributor

Description

This PR adds the possibility to alias the profile name to a custom one if the name of the aws account in rackspace is not satisfactory.

It also adds two new options to the script:

  • --no-export which causes AWS_PROFILE to remain untouched
  • --debug which enables set -x for the duration of the script for easy debugging of executed statements

Verification

Tested locally with the following options:

  • aws_login --no-export --debug <aws_account_no>=<profile_alias>
  • aws_login --no-export <aws_account_no>=<profile_alias>
  • aws_login --no-export <aws_account_no>=
  • aws_login --no-export =<profile_alias>
  • aws_login --no-export =
  • all of the above without --no-export

Checklist

  • My code follows the style guidelines of the project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation

Copy link

Hey @PascalFrenz! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

@PascalFrenz PascalFrenz merged commit 9c0f5d6 into main May 24, 2024
12 checks passed
@PascalFrenz PascalFrenz deleted the frenzpa/add-aliasing-for-profiles branch May 24, 2024 22:37
@HapagLloydTechnicalUser

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants