max/min support nullable column (apache#17)

HappenLee · Jul 13, 2021 · 53788df · 53788df
1 parent 581bc03
commit 53788df
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/be/src/vec/aggregate_functions/aggregate_function_min_max.cpp b/be/src/vec/aggregate_functions/aggregate_function_min_max.cpp
@@ -64,9 +64,7 @@ AggregateFunctionPtr createAggregateFunctionMin(const std::string & name, const
 
 void registerAggregateFunctionMinMax(AggregateFunctionSimpleFactory& factory) {
  factory.registerFunction("max", createAggregateFunctionMax);
- factory.registerFunction("max", createAggregateFunctionMax, true);
  factory.registerFunction("min", createAggregateFunctionMin);
- factory.registerFunction("min", createAggregateFunctionMin, true);
 }
 
 } // namespace doris::vectorized
diff --git a/be/src/vec/aggregate_functions/aggregate_function_null.cpp b/be/src/vec/aggregate_functions/aggregate_function_null.cpp
@@ -102,6 +102,8 @@ void registerAggregateFunctionCombinatorNull(AggregateFunctionSimpleFactory& fac
  return function_combinator->transformAggregateFunction(nested_function, types, params);
  };
  factory.registerFunction("sum", creator, true);
+ factory.registerFunction("max", creator, true);
+ factory.registerFunction("min", creator, true);
 }
 
 } // namespace doris::vectorized
diff --git a/be/src/vec/aggregate_functions/aggregate_function_simple_factory.h b/be/src/vec/aggregate_functions/aggregate_function_simple_factory.h
@@ -81,8 +81,8 @@ class AggregateFunctionSimpleFactory {
  static AggregateFunctionSimpleFactory instance;
  std::call_once(oc, [&]() {
  registerAggregateFunctionSum(instance);
- registerAggregateFunctionCombinatorNull(instance);
  registerAggregateFunctionMinMax(instance);
+ registerAggregateFunctionCombinatorNull(instance);
  });
  return instance;
  }