Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call sortChange on th click #407

Merged
merged 2 commits into from
Feb 11, 2023

Conversation

timefordroids
Copy link
Contributor

Sometimes it's very hard to click on sort icons to sort a table column, especially on small screens. So6 it would be great to make the whole th clickable for sortable columns.

For example: https://element.eleme.io/#/en-US/component/table#sorting

@huangshuwei
Copy link
Collaborator

huangshuwei commented Oct 30, 2021

First of all, thank you for your contribution. It would be great to make the whole th clickable for sortable columns. But if you have both paging and filtering, these two operations will conflict.
video

@timefordroids
Copy link
Contributor Author

Oh, thank you. I'll fix it

@GeorgeNance
Copy link
Contributor

What if we made just the text itself clickable for sortable columns?

@micheldpcarlos
Copy link
Contributor

Do you have any plans to merge this one? I had to do some workaround to make it clickable.

@timefordroids
Copy link
Contributor Author

I'll try to update the PR on the next week

@timefordroids
Copy link
Contributor Author

I've updated the PR
@huangshuwei could you please take a look?

@huangshuwei
Copy link
Collaborator

@timefordroids Thank you for your contribution. It's really a nice job 👍

@huangshuwei huangshuwei merged commit bc2839d into Happy-Coding-Clans:master Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants