Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autosave during Ganon fight/game ending issues #5087

Open
Prelle opened this issue Feb 19, 2025 · 1 comment · May be fixed by #5088
Open

Autosave during Ganon fight/game ending issues #5087

Prelle opened this issue Feb 19, 2025 · 1 comment · May be fixed by #5088

Comments

@Prelle
Copy link

Prelle commented Feb 19, 2025

There are two issues here both related to the changes to auto save. One of them is relatively minor but could result in lost progress. The other is much more serious as it creates invalid saves that can no longer be loaded.

1: Auto saving is specifically disabled during the Ganon fight. This shouldn't be the case as you can manually pause and save the game at this point, and the file works fine when this is done, with the Master Sword being returned normally if you had lost it. The issue with disabling autosave here is that you could collect an item in Ganon's boss key chest or from a pot in the tower, and then expect the game to save this when soft resetting during the fight, potentially causing lost progress. The previous autosave settings could've prevented this by saving when the item is collected and/or the scene is changed.
2: Although autosave is also disabled during the Chamber of Sages scene after the boss fight, it is allowed at any point of the ending sequence after that. This means that the timed save, which is prevented during the whole Ganon fight and Sages cutscene, will immediately trigger a save when the scene of Ganon falling into the void begins. At this point, the save is now corrupted and cannot be loaded without crashing the game. Autosaving should not work during any part of the ending sequence as you cannot normally save the game at this point.

@Prelle
Copy link
Author

Prelle commented Feb 19, 2025

saves.zip

The attached saves demonstrate the problem. The first file is a corrupted save that was created by the autosave during the ending cutscene. Loading this save will crash the game.

The second save is a copy that was created after saving during the second Ganon fight, and works normally. It can be used to test the boss fights and ending.

@Archez Archez linked a pull request Feb 20, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant