Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude debug file and cutscene map from auto save #5088

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Archez
Copy link
Contributor

@Archez Archez commented Feb 20, 2025

Excludes the debug save file from auto saving. Nothing ever actually saved, but the notification was still emitting with "Game Saved". Changed GameInteractor::IsSaveLoaded to pass in false to exclude the debug save file.

Remove's Ganon's Lair from the auto save exclusion as now that we don't save upon collecting an item, the original issue requiring the exclusion is no long there (#2156)

Also adds CUTSCENE_MAP to the scene exclusion, which is the scene for the triforce godess, ganondorf, etc cutscenes. This addresses an issue where autosave would trigger after killing ganon during the end credits. The rest of the credits are handled by the GAMEMODE_NORMAL check.

Fixes #5087

Build Artifacts

Copy link
Contributor

@aMannus aMannus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not gonna make this blocking, but maybe we need to include this in the tooltip somehow so people know the soft reset save won't trigger when done in those scenes as well. This is mostly the reason why I didn't have the usual cutscene check in the auto save before.

Atleast the ones not appearing in post-ganon, as those make sense to anyone that it won't save your game after the game is finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autosave during Ganon fight/game ending issues
3 participants