Implement some basic benchmarking for seed generation #4353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
My main point of feedback on the concept would be to separate the concept of the timings from rando. So that any future code could take advantage of it.
Ideally the only thing you should see in the rando code would be like
PerfStart("[Rando] Seed Generation");
PerfStart("[Rando] Logic");
…
PerfStart("[Rando] Helpers");
…
PerfEnd("[Rando] Helpers");
…
PerfEnd("[Rando] Logic");
PerfStart("[Rando] Entrances");
…
PerfEnd("[Rando] Entrances");
PerfEnd("[Rando] Seed Generation");
You could also use enums and map those to a string for the log output if you don’t want to do string comparison
|
Sounds good, I did admit this is a messy WIP, and it looks like there's issues with how I used Chrono on other platforms, I just wanted to make sure my data was good as the amount of time seemingly taken by UpdateHandlers is shocking. |
Pepper0ni
changed the title
Malkierian
approved these changes
Sep 20, 2024
garrettjoecox
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some rough benchmarking to seed generation, Includes both timers that are logged and a benchmarking settings preset to help keep things consistent.
Build Artifacts