Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxy Rotation #778
base: alpha
Are you sure you want to change the base?
Proxy Rotation #778
Changes from 2 commits
620549c
7636050
a0263dd
88d7aa5
7a287b2
e5326e5
acd430e
7e27c82
a68b3bf
6d24ffc
1e12313
a8060d7
6eda06e
75da6cc
cdec75b
c25a4f3
25cbc73
61569a9
92eed16
3c2d936
ee0f14e
a47a0d0
31148af
a511e02
b9f68b4
265248c
3183587
ce40261
15beaea
92ef86e
1e86ef8
f1ef100
253a6ec
ba043d0
cdf2b28
7269253
0ed906c
1368e33
183ac89
3f458ca
40561fc
04c1f35
13ba193
75e9345
52b8817
2012bb8
d91ec1d
e5a5901
f055c30
f3fbb4a
0044216
6b826a5
dfb7b9f
9746abd
1648ec3
bae1305
b31f1a0
340f17e
9d695cb
80f0a4f
ad5395a
06f62a1
765018f
0ba6320
7377d5f
a10bdc8
5cbb9de
b4c5c08
323fc50
2436bd8
d092bb5
c7e4f31
fb4fd61
c707989
db8ed35
e5a67b6
b40eb98
d102ad5
94c1cb8
5c2171f
96aee13
01f19e6
d8a4442
ebadea7
9eb3dca
d9c1569
f7f49bd
ac7c311
3df8685
8a9fedb
fda822d
485af97
891ed0b
1bfbcf4
494c812
9319305
a3485d2
16cf946
021a0b3
5a6d7dd
7f0c314
bf1704b
2898e71
a6bf8fb
4c2d7a9
0fe6968
f1df53f
f7e19b7
16d8177
ef611b5
779438d
537733a
1004703
709769a
b4c7b17
bed40d6
98c8b51
d1e33c3
d9e93b9
9db43be
0e38e37
0957b32
1b5fb14
fe22a2e
dc91dd8
78abf2a
e470643
16c9a4a
6696154
f9c9eee
2c8002e
ef4e7e6
fbc3809
e1e143c
4dbbeeb
7090f5d
52585c0
fda3247
7f776ac
5134846
40dd1ad
5f4897f
30e0543
ff565b4
1dbc92e
4c33718
538faea
efc91ba
a6521ef
a547e79
bb0c46a
f59e886
aa0beda
a795d85
d8d206b
fd66e60
933d240
1d121a4
11aa281
1000e05
2693d7f
ce94705
d747451
c18d5ad
30b9bee
0ec1fed
58dc858
89045ab
b392ea4
7d858f2
fa0298e
9db4e1c
d3a4275
f71bd22
bcf1149
8781e49
84c1d34
ca09532
cd0861f
fe13f56
1895e6e
df3c81d
039099b
f5bf60e
ece3a80
ee5ea35
8627fec
dbb72cb
0665916
5069651
04b943e
e09878e
d6ca7ed
8812eca
487b1d3
4f4e527
b477cae
1718264
f007999
45a8b85
56408ef
b53241c
ed4e1ea
1cf50e0
f7796a4
3235aa9
080bc92
f2030b9
9996c8b
ec03aee
45f0a7e
8682896
58f852b
363bd6e
e3d6019
ce0dbf2
3caa800
7786572
04d342e
a0a39ba
c378ade
226c0cf
05b6943
b14e86f
151d7c1
b111eef
a304f68
96d442d
956006e
0900119
d2a7566
574ef28
ea3975f
0a17616
12e1419
6ebd2d5
526d462
8b5f765
1c0343e
0a7143b
ead4438
26d6127
4434e3b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't be suitable for merging unless it also supports the "default" configuration of no proxies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But since you're cycling each
AmazonMonitor
through all the items, it seems like that shouldn't be hard to add, you'd just need to make sure that if there are no proxies, to instantiate a singleAmazonMonitor
that uses the default connector.This PR changes the meaning of the
delay
parameter from a per-item delay to a per-connection/proxy delay. That still seems totally workable, though, as long as people running the code are aware of it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I wrote it so that the delay parameter still works as intended - it's still the delay for check per session/proxy which should keep them getting dogg'd (503). I kinda figured if you're not using proxies alpha is kinda useless; might as well use master branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree pretty strongly that alpha is useless without proxies. I was getting softbanned using master because it was doing stock checks while logged in. Alpha uses anonymous sessions for stock checking, which is a huge improvement. I successfully bought what I wanted (granted, an AMD CPU, not a GPU) using alpha with no proxies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've implemented a default mode with no proxies, though it looks ugly rn. Gonna try to clean it up once I figure out how.