Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Access Token Check and Redirect #321

Merged
merged 8 commits into from
Oct 28, 2024
Merged

Implement Access Token Check and Redirect #321

merged 8 commits into from
Oct 28, 2024

Conversation

ygowthamr
Copy link
Contributor

@ygowthamr ygowthamr commented Oct 28, 2024 •
edited
Loading

Description:

Fix #122

  • Added a check for the access token in localStorage.
  • Implemented a redirect to the main page if the token is absent.
  • Enhances security by preventing unauthorized access to protected routes.
  • Improves user experience by guiding users to the main entry point.
  • Changes are tested and ready for review.

@Harshdev098
Pls add labels, gssoc-extd,level3,hacktoberfest-accepted lables.

Harshdev098
Harshdev098 requested changes Oct 28, 2024
View reviewed changes
Copy link
Owner

@Harshdev098 Harshdev098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also don't add token check in signup and login page

public/choose-file.html Outdated Show resolved Hide resolved
public/choose-signup-file.html Outdated Show resolved Hide resolved
public/dashboard.html Show resolved Hide resolved
@ygowthamr ygowthamr requested a review from Harshdev098 October 28, 2024 13:09
@ygowthamr
Copy link
Contributor Author

@Harshdev098
Updated required changes pls check and merge my PR

@Harshdev098 Harshdev098 merged commit f9a7613 into Harshdev098:main Oct 28, 2024
1 check passed
@github-actions GitHub Actions
Copy link
Contributor

🎉🎉 Thank you for your contribution! Your PR #321 has been merged! 🎉🎉

@Harshdev098 Harshdev098 added hacktoberfest This issue belongs to hacktoberfest gssoc-ext This issue is under GSSoc Ext program level2 level2 lebel for gssoc level hacktoberfest-accepted label for accepted PRs under hacktoberfest labels Oct 28, 2024
@ygowthamr
Copy link
Contributor Author

ygowthamr commented Oct 28, 2024 •
edited
Loading

@Harshdev098
It is level3 issue pls give me level3.

@ygowthamr
Copy link
Contributor Author

@Harshdev098
Pls change this pr level from level2 to level3.

@ygowthamr
Copy link
Contributor Author

@Harshdev098
Can you pls update the level to level3 before the gssoc leaderboard update.

@Harshdev098 Harshdev098 added level3 labe3 label for gssoc and removed level2 level2 lebel for gssoc level labels Oct 28, 2024
@ygowthamr
Copy link
Contributor Author

@Harshdev098
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harshdev098 Harshdev098 Awaiting requested review from Harshdev098

Assignees
No one assigned
Labels
gssoc-ext This issue is under GSSoc Ext program hacktoberfest This issue belongs to hacktoberfest hacktoberfest-accepted label for accepted PRs under hacktoberfest level3 labe3 label for gssoc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature : Adding Sessions to the App
2 participants
@ygowthamr @Harshdev098