Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: changed website logo and fixed minor bug #425

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

trinetra110
Copy link
Contributor

📋 Description

Changed the website logo on various pages, added it to the home page and added the home page link in some of them. Also fixed a minor bug for accessing the faculty login page.

🔨 Changes Made

  • Added the logos in PNG format: logo1, logo2 and logo3
  • Changed them with the old logo.png and added the home page link in some of them.
  • Fixed a minor bug of token checking in "fac_login.html"

✅ Checklist

Before submitting the PR, please make sure you have completed the following:

  • I have followed all the guidelines mentioned in CONTRIBUTING.md.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation (if applicable).
  • I have tested it locally and it works fine.
  • Any dependent changes have been merged and published in downstream modules.

🏷️ Types of Changes

What type of changes does your code introduce? (Check all that apply)

  • Bug fix (non-breaking change which fixes an issue) 🐛

  • New feature (non-breaking change which adds functionality) ✨

  • UI enhancement (non-breaking change which enhances UI) 🎨

  • Documentation update 📚

  • Fixes Feat: Changing Website Logo  #421

📸 Screenshots (if applicable)

Can't take so many SS, so uploading 1.

Screenshot 2024-11-10 135143


Thank you for contributing to Research Nexus! We look forward to reviewing your PR and getting it merged!

@trinetra110
Copy link
Contributor Author

@Harshdev098 I have made the required changes. Please review it and add the 'gssoc-ext' and 'level2' tags.

Copy link
Owner

@Harshdev098 Harshdev098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also change the favicon on every page

@trinetra110
Copy link
Contributor Author

Also change the favicon on every page

@Harshdev098 done; please check.

@Harshdev098 Harshdev098 merged commit e1387fb into Harshdev098:main Nov 10, 2024
1 check passed
@Harshdev098 Harshdev098 added gssoc-ext This issue is under GSSoc Ext program level2 level2 lebel for gssoc level labels Nov 10, 2024
Copy link
Contributor

🎉🎉 Thank you for your contribution! Your PR #425 has been merged! 🎉🎉

@trinetra110 trinetra110 deleted the logo branch November 10, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext This issue is under GSSoc Ext program level2 level2 lebel for gssoc level
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Changing Website Logo
2 participants