Feature/django1 10 monkeypatching fix #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oving that method into the django.urls package.
sapnamysore
reviewed
Mar 16, 2017
tests/urls.py
Outdated
|
|
||
| urlpatterns = [ | ||
| # url(r'^admin/', admin.site.urls), | ||
| ] |
There was a problem hiding this comment.
Do we need this as there are no urls?
There was a problem hiding this comment.
Ah, I see this is referenced in the settings..
Can the commented lines be cleaned up?
There was a problem hiding this comment.
I'll actually just remove the module entirely since it's not being used. I had intended to add some tests related to monkey-patching, but it's more complicated than I thought so we can rely on manual testing for now.
sapnamysore
reviewed
Mar 16, 2017
| 'ENGINE': 'django.db.backends.sqlite3', | ||
| 'NAME': os.path.join(BASE_DIR, 'db.sqlite3'), | ||
| } | ||
| } |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
patch_reversemodule, used by MultiLTILaunchMiddleware, to be compatible with Django 1.10. In prior verisons of Django, thereversemethod was located within theurlresolversmodule withindjango.core. In 1.10+, there is a newurlsmodule which importsreversefrom a sub-module. We need to patch that inclusion, as well as the import ofreversewithindjango.shortcuts.This PR also splits out the test cases for the reusable application into a
testsmodule outside of the application package and introducestoxto make testing across Django versions easier.@sapnamysore
@cmurtaugh