TLT-4135 (feat) add setting to exclude views #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- paths matching entries in the new Django setting will not be processed as part of LTI sessions - update to tox to support recent versions of django and python - github actions workflow to run tests against different versions of django and python
PatrickMTonne
approved these changes
Apr 13, 2022
LICENSE
Outdated
| @@ -1,4 +1,4 @@ | |||
| Copyright 2016 The President and Fellows of Harvard College | |||
| Copyright 2021 The President and Fellows of Harvard College | |||
There was a problem hiding this comment.
Just curious: should this be 2022?
There was a problem hiding this comment.
Ah yeah, good point. TBH I'm not sure when, exactly, we need to update the copyright, and some libraries/resources I've seen don't even include a date/year.
Seems we've had discussions of this in the past and don't always bump it -- there's some set of criteria that are used, that I'm not aware of/can't remember. Maybe @cmurtaugh has some insight?
I'll update to 2022 for now.
| # importing here will ensure that django.urls.reverse is patched | ||
| # for other libraries and parts of django, e.g. `url` template tag, | ||
| # when the middleware is loaded | ||
| import django_auth_lti.patch_reverse |
There was a problem hiding this comment.
Thanks for highlighting this. I wouldn't have given a second thought to the change in import order had this not been there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help clean up logs for our apps using
django-auth-lti:To stop logging "Could not find LTI launch for resource_link_id None" for
/w/ping, for example, you can add this to your Django settings:For more info please see the README.